hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhankun Tang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5394) Remove bind-mount /etc/passwd to Docker Container
Date Sat, 30 Jul 2016 15:07:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-5394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400698#comment-15400698
] 

Zhankun Tang commented on YARN-5394:
------------------------------------

The failed unit test "TestNMProxy" seems unrelated to this patch. I submited it with both
"Affects version" and "target version" set to 2.8.0. Is this the reason causes "TestNMProxy"
failure? *Or maybe I need to test it against trunk*?

I checked the code of the failed test case "testNMProxyRPCRetry" in branch-2.8. It seems that
it should failed since no exception contains the expected string "Failed on local exception:
java.net.SocketException". And in trunk, the same test case just assert the class type rather
than string comparison.
{code:title=TestNMProxy.java(branch-2.8)}
    try {
      proxy.startContainers(allRequests);
      Assert.fail("should get socket exception");
    } catch (IOException e) {
      // socket exception should be thrown immediately, without RPC retries.
      Assert.assertTrue(e.toString().
          contains("Failed on local exception: java.net.SocketException"));
    }
{code}

{code:title=TestNMProxy.java(trunk)}
    try {
      proxy.startContainers(allRequests);
      Assert.fail("should get socket exception");
    } catch (IOException e) {
      // socket exception should be thrown immediately, without RPC retries.
      Assert.assertTrue(e instanceof java.net.SocketException);
    }
{code}

> Remove bind-mount /etc/passwd to Docker Container
> -------------------------------------------------
>
>                 Key: YARN-5394
>                 URL: https://issues.apache.org/jira/browse/YARN-5394
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn
>    Affects Versions: 2.8.0
>            Reporter: Zhankun Tang
>            Assignee: Zhankun Tang
>              Labels: patch
>         Attachments: YARN-5394-branch-2.8.001.patch, YARN-5394-branch-2.8.002.patch
>
>
> Current LCE (DockerLinuxContainerRuntime) is mounting /etc/passwd to the container. And
it seems uses wrong file name "/etc/password" for container.
> {panel}
> .addMountLocation("/etc/passwd", "/etc/password:ro");
> {panel}
> The biggest issue of bind-mount /etc/passwd is that it overrides the users defined in
Docker image which is not expected. Remove it won't affect existing use cases.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message