hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5382) RM does not audit log kill request for active applications
Date Fri, 15 Jul 2016 15:29:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379561#comment-15379561
] 

Jason Lowe commented on YARN-5382:
----------------------------------

Thanks for the patch, [~vrushalic]!

I don't think we should do a vanilla log here.  It won't appear in the audit log stream, and
that's where users are going to look if they have configured the audit log to a separate file
(as we have).  We should simply audit log a success here, as for all practical purposes it
is a success.  We verified the app ID is valid, active, and the user has permissions to do
so.  At this point the only race is whether the app completes before the kill arrives, but
we already log success when the kill arrives after the app completes, so why not here as well?

> RM does not audit log kill request for active applications
> ----------------------------------------------------------
>
>                 Key: YARN-5382
>                 URL: https://issues.apache.org/jira/browse/YARN-5382
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.7.2
>            Reporter: Jason Lowe
>            Assignee: Vrushali C
>         Attachments: YARN-5382-branch-2.7.01.patch
>
>
> ClientRMService will audit a kill request but only if it either fails to issue the kill
or if the kill is sent to an already finished application.  It does not create a log entry
when the application is active which is arguably the most important case to audit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message