hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arun Suresh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5351) ResourceRequest should take ExecutionType into account during comparison
Date Mon, 11 Jul 2016 17:19:11 GMT

    [ https://issues.apache.org/jira/browse/YARN-5351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371190#comment-15371190
] 

Arun Suresh commented on YARN-5351:
-----------------------------------

Thanks for the patch [~kkaranasos]..
I don't think you need to compare the ExecutionTypeRequest.. Just the ExecutionType.
Since the RemoteRequestTable uses just the ExecutionType, not the ExecutionTypeRequest to
key the outstanding requests.
The rationale is similar to location, where you just use the resourceName / hostname in the
compare method, not the relaxLocality boolean flag.


> ResourceRequest should take ExecutionType into account during comparison
> ------------------------------------------------------------------------
>
>                 Key: YARN-5351
>                 URL: https://issues.apache.org/jira/browse/YARN-5351
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Konstantinos Karanasos
>            Assignee: Konstantinos Karanasos
>         Attachments: YARN-5351.001.patch
>
>
> {{ExecutionTypeRequest}} should be taken into account in the {{compareTo}} method of
{{ResourceRequest}}.
> Otherwise, in the {{ask}} list of the {{AMRMClientImpl}} we may incorrectly add pending
container requests in the presence of both GUARANTEED and OPPORTUNISTIC containers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message