hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Subru Krishnan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5283) Refactor container assignment into AbstractYarnScheduler#assignContainers
Date Fri, 08 Jul 2016 23:35:11 GMT

    [ https://issues.apache.org/jira/browse/YARN-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368720#comment-15368720
] 

Subru Krishnan commented on YARN-5283:
--------------------------------------

Thanks [~rchiang] for driving this effort, overall I think it'll be very useful.

The changes I am making as part of YARN-4888 are in {{reserve}}/{{getContainer}} in _Capacity/Fair/Fifo_
schedulers (even there looks like quite similar code).

Regarding the patch - is there an opportunity to move common logic to {{AbstractYarnScheduler::assignContainers}}
like the {{isReadyToAssignContainers}} check?

> Refactor container assignment into AbstractYarnScheduler#assignContainers
> -------------------------------------------------------------------------
>
>                 Key: YARN-5283
>                 URL: https://issues.apache.org/jira/browse/YARN-5283
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacity scheduler, fairscheduler, resourcemanager, scheduler
>            Reporter: Ray Chiang
>            Assignee: Ray Chiang
>         Attachments: YARN-5283.001.patch
>
>
> CapacityScheduler#allocateContainersToNode() and FairScheduler#attemptScheduling() have
some common code that can be refactored into a common abstract method like AbstractYarnScheduler#assignContainers().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message