hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-5270) Solve miscellaneous issues caused by YARN-4844
Date Thu, 07 Jul 2016 21:32:11 GMT

    [ https://issues.apache.org/jira/browse/YARN-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366807#comment-15366807
] 

Jian He edited comment on YARN-5270 at 7/7/16 9:31 PM:
-------------------------------------------------------

- should the proto definition be reverted to int32 too ?
{code}
 optional int64 virtual_cores = 2;
{code}
- unnecessary converting to int in many places, please check the caller of getVirtualCores
to revert those changes.
{code}
getMetrics().getReservedMB(), (int) getMetrics()
    .getReservedVirtualCores()),
{code}

{code}
(int) rootMetrics.getAvailableVirtualCores()) +
{code}
{code}
etMetrics().getReservedMB(), (int) getMetrics()
    .getReservedVirtualCores()), schedulingMode)) {
{code}
- import Evolving directly, to make the API javadoc view more consistent
{code}
  @Public
  @InterfaceStability.Evolving
{code}


was (Author: jianhe):
- should the proto definition be reverted to int32 too ?
{code}
 optional int64 virtual_cores = 2;
{code}
- unnecessary converting to int in many places, please check the caller of getVirtualCores
to revert those changes.
{code}
getMetrics().getReservedMB(), (int) getMetrics()
    .getReservedVirtualCores()),
{code}

{code}
(int) rootMetrics.getAvailableVirtualCores()) +
{code}
{code}
etMetrics().getReservedMB(), (int) getMetrics()
    .getReservedVirtualCores()), schedulingMode)) {
{code}
- import Evolving directly, to make the API javadoc view more consistent
{code}
@Public
@InterfaceStability.Evolving
{code}

> Solve miscellaneous issues caused by YARN-4844
> ----------------------------------------------
>
>                 Key: YARN-5270
>                 URL: https://issues.apache.org/jira/browse/YARN-5270
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>            Priority: Blocker
>         Attachments: YARN-5270-branch-2.001.patch, YARN-5270-branch-2.002.patch, YARN-5270-branch-2.003.patch,
YARN-5270-branch-2.8.001.patch, YARN-5270-branch-2.8.002.patch, YARN-5270-branch-2.8.003.patch,
YARN-5270.003.patch
>
>
> Such as javac warnings reported by YARN-5077 and type converting issues in Resources
class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message