hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Li Lu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5229) Refactor #isApplicationEntity and #getApplicationEvent from HBaseTimelineWriterImpl
Date Wed, 06 Jul 2016 20:16:11 GMT

    [ https://issues.apache.org/jira/browse/YARN-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15365007#comment-15365007
] 

Li Lu commented on YARN-5229:
-----------------------------

Refactor LGTM. [~vrushalic] could you please address the two issues raised by hadoop qa? I
think those two points are valid. Thanks! 

> Refactor #isApplicationEntity and #getApplicationEvent from HBaseTimelineWriterImpl
> -----------------------------------------------------------------------------------
>
>                 Key: YARN-5229
>                 URL: https://issues.apache.org/jira/browse/YARN-5229
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Joep Rottinghuis
>            Assignee: Vrushali C
>            Priority: Minor
>         Attachments: YARN-5229-YARN-2928.01.patch, YARN-5229-YARN-2928.02.patch, YARN-5229-YARN-2928.03.patch
>
>
> As per [~gtCarrera9] commented in YARN-5170
> bq. In HBaseTimelineWriterImpl isApplicationEntity and getApplicationEvent seem to be
awkward. Looks more like something related to TimelineEntity or ApplicationEntity
> In YARN-5170 we just made the method private, and in this separate jira we can refactor
these methods to TimelineEntity or ApplicationEntity.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message