hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5121) fix some container-executor portability issues
Date Fri, 29 Jul 2016 22:51:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400171#comment-15400171
] 

Chris Nauroth commented on YARN-5121:
-------------------------------------

[~aw], thank you for this patch.  I have confirmed a successful full build and run of test-container-executor
on OS X and Linux.

Just a few questions:

bq. For hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/compat/{fstatat|openat|unlinkat}.h:

I just want to double-check with you that the fchmodat.h and fdopendir.h implementations are
not BSD-licensed, and that's why they're not listed in LICENSE.txt and instead have an Apache
license header.  Is that correct?

{code}
  fprintf(stderr,"ret = %s\n", ret);
{code}

Chris D mentioned previously that this might have been a leftover from debugging.  Did you
intend to keep it, or should we drop it?

{code}
char* get_executable() {
 return __get_exec_readproc("/proc/self/path/a.out");
}
{code}

Please check the indentation on the return statement.

Is "/proc/self/path/a.out" correct?  The /proc/self part makes sense to me, but the rest of
it surprised me.  Is that a.out like the default gcc binary output path?  I have nearly zero
experience with Solaris, so I trust your knowledge here.  :-)


> fix some container-executor portability issues
> ----------------------------------------------
>
>                 Key: YARN-5121
>                 URL: https://issues.apache.org/jira/browse/YARN-5121
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Blocker
>         Attachments: YARN-5121.00.patch, YARN-5121.01.patch, YARN-5121.02.patch, YARN-5121.03.patch,
YARN-5121.04.patch, YARN-5121.06.patch
>
>
> container-executor has some issues that are preventing it from even compiling on the
OS X jenkins instance.  Let's fix those.  While we're there, let's also try to take care of
some of the other portability problems that have crept in over the years, since it used to
work great on Solaris but now doesn't.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message