hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohith Sharma K S (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5101) YARN_APPLICATION_UPDATED event is parsed in ApplicationHistoryManagerOnTimelineStore#convertToApplicationReport with reversed order
Date Wed, 13 Jul 2016 11:36:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-5101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374861#comment-15374861
] 

Rohith Sharma K S commented on YARN-5101:
-----------------------------------------

Thanks Sunil for providing patch. Overall patch looks good to me.
Not from your patch , small nit. Can you use systemClock for publishing appUpdate event instead
of {{System.currentTimeMillis()}} in below classes
# RMAppImple : line number 1057
# CS : line number 2114

> YARN_APPLICATION_UPDATED event is parsed in ApplicationHistoryManagerOnTimelineStore#convertToApplicationReport
with reversed order
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-5101
>                 URL: https://issues.apache.org/jira/browse/YARN-5101
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.8.0
>            Reporter: Xuan Gong
>            Assignee: Sunil G
>         Attachments: YARN-5101.0001.patch
>
>
> Right now, the application events are parsed in in ApplicationHistoryManagerOnTimelineStore#convertToApplicationReport
with timestamp descending order, which means the later events would be parsed first, and the
previous same type of events would override the information. In
> https://issues.apache.org/jira/browse/YARN-4044, we have introduced YARN_APPLICATION_UPDATED
events which might be submitted by RM multiple times in one application life cycle. This could
cause problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message