hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arun Suresh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4888) Changes in RM container allocation for identifying resource-requests explicitly
Date Fri, 29 Jul 2016 14:45:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-4888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399430#comment-15399430
] 

Arun Suresh commented on YARN-4888:
-----------------------------------

[~subru], I see just a few minor nits:

# I feel the *UNDEFINED* SchedulerRequestKey should have allocationRequestId = -1 instance
of 0 (to follow Priority)
# Shouldnt the comparison be (o.allocationRequestId - getAllocationRequestId())  to maintain
similar sort order as priority ?
# In {{RegularContainerAllocator}}, you can revert the spurious changes in the imports
# ditto in {{FiCaSchedulerApp}}, {{FSAppAttempt}}, {{TestCapacityScheduler}} and {{TestFairScheduler}}

Thanks for the extensive tests.

> Changes in RM container allocation for identifying resource-requests explicitly
> -------------------------------------------------------------------------------
>
>                 Key: YARN-4888
>                 URL: https://issues.apache.org/jira/browse/YARN-4888
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Subru Krishnan
>            Assignee: Subru Krishnan
>         Attachments: YARN-4888-WIP.patch, YARN-4888-v0.patch, YARN-4888-v2.patch, YARN-4888-v3.patch,
YARN-4888.001.patch
>
>
> YARN-4879 puts forward the notion of identifying allocate requests explicitly. This JIRA
is to track the changes in RM app scheduling data structures to accomplish it. Please refer
to the design doc in the parent JIRA for details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message