hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-3662) Federation Membership State APIs
Date Wed, 13 Jul 2016 22:51:20 GMT

    [ https://issues.apache.org/jira/browse/YARN-3662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375947#comment-15375947
] 

Wangda Tan commented on YARN-3662:
----------------------------------

Hi [~subru],

I took a very quick look at this patch and also YARN-3664/YARN-5367, I put all questions and
comments here:

Questions:
- Could not quite sure about what is FederationPolicy and how to use the class. Is it a state
or a configuration? And why compressing parameters into a byte array instead more meaningful
fields?
- It could be better to add RPC service interface definitions of FederationPolicy storage
API for easier review, now I cannot understand how these protocol definitions will be used.

(Highlevel) Comments:
- FederationMembershipState looks like a "state manager" since it supports operations to modify
existing members. At the first glance, it's a sub-cluster-resource-tracker which is similar
to existing RM resource tracker.
- Similiarly, FederationApplicationState looks like a "federation-application-manager" instead
of a "state".
- FederationMembershipState has same parameter FederationSubClusterInfo for register/heartbeat
-- is it possible that we require different parameter for registration and heartbeat? (Just
like NM registration request and NM update request).
- FederationSubClusterInfo: fields like amRMAddress is actually a service endpoint, names
of these fields are little confusing to me.

Styles:
- redundunt "public" in all interface definitions (considering switching to Intellij instead
of Eclipse? :-p)

Thanks,

> Federation Membership State APIs
> --------------------------------
>
>                 Key: YARN-3662
>                 URL: https://issues.apache.org/jira/browse/YARN-3662
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Subru Krishnan
>            Assignee: Subru Krishnan
>         Attachments: YARN-3662-YARN-2915-v1.1.patch, YARN-3662-YARN-2915-v1.patch, YARN-3662-YARN-2915-v2.patch
>
>
> The Federation Application State encapsulates the information about the active RM of
each sub-cluster that is participating in Federation. The information includes addresses for
ClientRM, ApplicationMaster and Admin services along with the sub_cluster _capability_ which
is currently defined by *ClusterMetricsInfo*. Please refer to the design doc in parent JIRA
for further details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message