Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 9 Jun 2016 00:39:20 +0000 (UTC)
From: "Carlo Curino (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12971826.1463865478000.34790.1465432760997@Atlassian.JIRA>
In-Reply-To: <JIRA.12971826.1463865478000@Atlassian.JIRA>
References: <JIRA.12971826.1463865478000@Atlassian.JIRA> <JIRA.12971826.1463865478825@arcas>
Subject: [jira] [Commented] (YARN-5124) Modify AMRMClient to set the
 ExecutionType in the ResourceRequest
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 09 Jun 2016 00:39:22 -0000


    [ https://issues.apache.org/jira/browse/YARN-5124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15321713#comment-15321713 ] 

Carlo Curino commented on YARN-5124:
------------------------------------

[~asuresh] this seems better, however you still have the typedefs in the new class, and you have foreach loops on Object that are a bit weird. Would it be possible to move into the {{RemoteRequestTable}} the {{addResourceRequest}}, {{decResourceRequest}} and {{getMatchingRequests}}. This could simplify further the {{AMRMClientImpl}} and delegate to the db-style class all matter of data access.

Concretely I propose:
1) get rid of the typedefs
2) move the add/dec/get to the RemoteRequestTable
3) create a new getter to support {{checkLocalityRelaxationConflict}} where the matching is done internally in  {{RemoteRequestTable}} and the external method operates on a narrowly typed list (built by the getter).

This would fully encapsulate the data storage/access and allow you to evolve that independently of the external business-logic classes.

> Modify AMRMClient to set the ExecutionType in the ResourceRequest
> -----------------------------------------------------------------
>
>                 Key: YARN-5124
>                 URL: https://issues.apache.org/jira/browse/YARN-5124
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: YARN-5124.001.patch, YARN-5124.002.patch, YARN-5124.003.patch, YARN-5124.004.patch, YARN-5124.005.patch, YARN-5124.006.patch, YARN-5124.008.patch, YARN-5124.009.patch, YARN-5124.010.patch, YARN-5124.011.patch, YARN-5124.012.patch, YARN-5124_YARN-5180_combined.007.patch, YARN-5124_YARN-5180_combined.008.patch
>
>
> Currently the {{ContainerRequest}} allows the AM to set the {{ExecutionType}} in the AMRMClient, but it is not being set in the actual {{ResourceRequest}} that is sent to the RM 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org