Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 14 Jun 2016 21:46:30 +0000 (UTC)
From: "Sangjin Lee (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12967057.1462901138000.1733.1465940790203@Atlassian.JIRA>
In-Reply-To: <JIRA.12967057.1462901138000@Atlassian.JIRA>
References: <JIRA.12967057.1462901138000@Atlassian.JIRA> <JIRA.12967057.1462901138152@arcas>
Subject: [jira] [Commented] (YARN-5070) upgrade HBase version for first
 merge
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 14 Jun 2016 21:46:32 -0000


    [ https://issues.apache.org/jira/browse/YARN-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330682#comment-15330682 ] 

Sangjin Lee commented on YARN-5070:
-----------------------------------

Thanks [~vrushalic] for the updated patch! The patch looks good for the most part. I only have a couple of minor points.

(FlowScanner.java)
- The 2 constructors are essentially duplicates except for {{batchSize}}. How about having one constructor call the other to eliminate the duplication? For example,
{code}
FlowScanner(RegionCoprocessorEnvironment env, InternalScanner internalScanner,
    FlowScannerOperation action) {
  this(env, null, internalScanner, action);
}

FlowScanner(RegionCoprocessorEnvironment env, Scan incomingScan,
    InternalScanner internalScanner, FlowScannerOperation action) {
  this.batchSize = incomingScan == null ? -1 : incomingScan.getBatch();
  ...
}
{code}
- l.148, 160: it appears for {{ScannerContext}} that batch size of -1 would mean immediately reaching the limit? I'm looking at {{ScannerContext.checkBatchLimit()}}. We learned that these methods are not really exercised, but perhaps we can simply not set any batch limit to be on the safe side?

> upgrade HBase version for first merge
> -------------------------------------
>
>                 Key: YARN-5070
>                 URL: https://issues.apache.org/jira/browse/YARN-5070
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Vrushali C
>            Priority: Critical
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-5070-YARN-2928.01.patch, YARN-5070-YARN-2928.02.patch, YARN-5070-YARN-2928.03.patch, YARN-5070-YARN-2928.04.patch, YARN-5070-YARN-2928.05.patch
>
>
> Currently we set the HBase version for the timeline service storage to 1.0.1. This is a fairly old version, and there are reasons to upgrade to a newer version. We should upgrade it.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org