From yarn-issues-return-89387-apmail-hadoop-yarn-issues-archive=hadoop.apache.org@hadoop.apache.org Tue Jun 21 16:58:59 2016 Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5A0B419FD2 for ; Tue, 21 Jun 2016 16:58:59 +0000 (UTC) Received: (qmail 47499 invoked by uid 500); 21 Jun 2016 16:58:59 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 47420 invoked by uid 500); 21 Jun 2016 16:58:58 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 47369 invoked by uid 99); 21 Jun 2016 16:58:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Jun 2016 16:58:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 13FE32C1F6B for ; Tue, 21 Jun 2016 16:58:58 +0000 (UTC) Date: Tue, 21 Jun 2016 16:58:58 +0000 (UTC) From: "Sunil G (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-5242) Update DominantResourceCalculator to consider all resource types in calculations MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-5242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342174#comment-15342174 ] Sunil G commented on YARN-5242: ------------------------------- HI [~vvasudev] Thanks for the patch. A quick doubt. {{fitsIn}} is generally used as a public API in many critical places inside scheduler. In this patch, {{IllegalArgumentException}} is thrown and it may fail heartbeats etc. As I see, we were handling 2 return cases from *fitsIn* (success / failure). Could we report failure instead of exception. Or do you see this as a recurring failure which needs to handled as fail-fast? > Update DominantResourceCalculator to consider all resource types in calculations > -------------------------------------------------------------------------------- > > Key: YARN-5242 > URL: https://issues.apache.org/jira/browse/YARN-5242 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Varun Vasudev > Assignee: Varun Vasudev > Attachments: YARN-5242-YARN-3926.001.patch, YARN-5242-YARN-3926.002.patch > > > The fitsIn function in the DominantResourceCalculator only looks at memory and cpu. It should be modified to use all available resource types. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org