From yarn-issues-return-88727-apmail-hadoop-yarn-issues-archive=hadoop.apache.org@hadoop.apache.org Fri Jun 10 20:40:21 2016 Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 656E018BC9 for ; Fri, 10 Jun 2016 20:40:21 +0000 (UTC) Received: (qmail 53947 invoked by uid 500); 10 Jun 2016 20:40:21 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 53897 invoked by uid 500); 10 Jun 2016 20:40:21 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 53869 invoked by uid 99); 10 Jun 2016 20:40:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Jun 2016 20:40:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 0269F2C1F5C for ; Fri, 10 Jun 2016 20:40:21 +0000 (UTC) Date: Fri, 10 Jun 2016 20:40:21 +0000 (UTC) From: "Joep Rottinghuis (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (YARN-5235) Avoid re-creation of EvenColumnNameConverter in HBaseTimelineWriterImpl#storeEvents MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joep Rottinghuis updated YARN-5235: ----------------------------------- Description: As per discussion in YARN-5170 [~varun_saxena] noted: bq. In HBaseTimelineWriterImpl#storeEvents, we iterate over all events in a loop and will be creating EventColumnNameConverter object each time. Although its not a very heavy object right now, but can't we just create it once outside the loop ? was: As per discussion in YARN-5052 [~varun_saxena] noted: bq. In HBaseTimelineWriterImpl#storeEvents, we iterate over all events in a loop and will be creating EventColumnNameConverter object each time. Although its not a very heavy object right now, but can't we just create it once outside the loop ? > Avoid re-creation of EvenColumnNameConverter in HBaseTimelineWriterImpl#storeEvents > ----------------------------------------------------------------------------------- > > Key: YARN-5235 > URL: https://issues.apache.org/jira/browse/YARN-5235 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver > Affects Versions: YARN-2928 > Reporter: Joep Rottinghuis > Assignee: Joep Rottinghuis > Priority: Trivial > > As per discussion in YARN-5170 [~varun_saxena] noted: > bq. In HBaseTimelineWriterImpl#storeEvents, we iterate over all events in a loop and will be creating EventColumnNameConverter object each time. Although its not a very heavy object right now, but can't we just create it once outside the loop ? -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org