[ https://issues.apache.org/jira/browse/YARN-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328711#comment-15328711 ] 

Junping Du commented on YARN-5224:
----------------------------------

Thanks [~xgong] for the patch. A few comments:
1. For the new added webservice API, it is better to be self-description. Because we already have Path("/containerlogs/{containerid}/{filename}") to mark getting specific log file content against specific containerId, user could misunderstand that Path("/containerlogs/container/{containerid}") represent of getting all log file content against specific containerId which is not the case here. May be we should update the api to something like: Path("/containerlogs/{containerid}/logFiles") for get all log files' paths?

2. In  getContainerLogFiles(), we swallow the exception silently which will make it very hard to debug. We should either throw exceptions out or at least log it out or we will never find the reason why returned logFiles are empty or partially.

3. I see we support both MediaType of APPLICATION_JSON and MediaType.APPLICATION_XML but our CLI is using XML type instead of JSON. In my understanding, this particular structure of plain list is much easier and concisely to use JSON instead XML. So an optional improvement in future could be replacing XML with JSON.

The checkstyle, whitespace warnings are not valid. I think test failure in TestYARNClient is not related. Isn't it?

> Logs for a completed container are not available in the yarn logs output for a live application
> -----------------------------------------------------------------------------------------------
>
>                 Key: YARN-5224
>                 URL: https://issues.apache.org/jira/browse/YARN-5224
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 2.9.0
>            Reporter: Siddharth Seth
>            Assignee: Xuan Gong
>         Attachments: YARN-5224.1.patch, YARN-5224.2.patch
>
>
> This affects 'short' jobs like MapReduce and Tez more than long running apps.
> Related: YARN-5193 (but that only covers long running apps)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org