From yarn-issues-return-88089-apmail-hadoop-yarn-issues-archive=hadoop.apache.org@hadoop.apache.org Sat Jun 4 12:42:59 2016 Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8F7FD19652 for ; Sat, 4 Jun 2016 12:42:59 +0000 (UTC) Received: (qmail 82178 invoked by uid 500); 4 Jun 2016 12:42:59 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 82130 invoked by uid 500); 4 Jun 2016 12:42:59 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 82119 invoked by uid 99); 4 Jun 2016 12:42:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Jun 2016 12:42:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 3362A2C1F64 for ; Sat, 4 Jun 2016 12:42:59 +0000 (UTC) Date: Sat, 4 Jun 2016 12:42:59 +0000 (UTC) From: "Varun Saxena (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: =?utf-8?Q?[jira]_[Commented]_(YARN-519?= =?utf-8?Q?1)_Rename_the_=E2=80=9Cdownload=3Dtrue?= =?utf-8?Q?=E2=80=9D_option_for_getLogs_in_NMWe?= =?utf-8?Q?bServices_and_AHSWebServices?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-5191?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D15315= 485#comment-15315485 ]=20 Varun Saxena commented on YARN-5191: ------------------------------------ Was looking at the code added with regards to log tooling enhancement. Foun= d that we haven't closed LogReader in AHSWebServices#getStreamingOutput. This would lead to connections with datanode stuck in CLOSE_WAIT state and = may eventually lead to too many open files error. I think this needs to be fixed. This issue is not directly related to this JIRA but to code added in one of= JIRA in parent. As this was one of the related ongoing JIRA, just commente= d here to bring attention to the issue so that it can be handled, maybe in = this JIRA itself ? Moreover, in NMWebServices#getLogs we do not close FileInputStream. This is= not a very big issue as FileInputStream has finalize method which would cl= ose the input stream. But this would mean that the corresponding FDs' will = be hanging around till next cycle of GC happens. This can be fixed as well = although this seems to be a very old issue. > Rename the =E2=80=9Cdownload=3Dtrue=E2=80=9D option for getLogs in NMWebS= ervices and AHSWebServices > -------------------------------------------------------------------------= -------- > > Key: YARN-5191 > URL: https://issues.apache.org/jira/browse/YARN-5191 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Xuan Gong > Assignee: Xuan Gong > Attachments: YARN-5191.1.patch, YARN-5191.2.patch, YARN-5191.3.pa= tch, YARN-5191.4.patch > > > Rename the =E2=80=9Cdownload=3Dtrue=E2=80=9D option to instead be somethi= ng like =E2=80=9Cformat=3Doctet-stream=E2=80=9D, so that we are explicit -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org