hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joep Rottinghuis (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5239) Eliminate unused imports checkstyle warnings
Date Mon, 13 Jun 2016 17:01:21 GMT

    [ https://issues.apache.org/jira/browse/YARN-5239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15327751#comment-15327751
] 

Joep Rottinghuis commented on YARN-5239:
----------------------------------------

Ah, indeed. I confirmed Eclipse was happy following the line breaks in package hierarchy for
javadoc.
I suppose either the javadoc checker, or the checkstyle needs to be fixed, or both.

I'll close this jira as won't fix then. At least we now have two documented attempts at reducing
the checkstyle issues...

> Eliminate unused imports checkstyle warnings
> --------------------------------------------
>
>                 Key: YARN-5239
>                 URL: https://issues.apache.org/jira/browse/YARN-5239
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Joep Rottinghuis
>            Assignee: Joep Rottinghuis
>            Priority: Trivial
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-5239-YARN-2928.01.patch
>
>
> There are ~8 existing checkstyle issues generated due to unused imports.
> By fully qualifying the classes in javadoc and manually wrapping the javadoc under 80
characters we can eliminate these warnings.
> This will help with the eventual merge because then we introduce 8 fewer checkstyle warnings.
> The only checkstyle warnings left are now too many arguments, which cannot be easily
refactored w/o changing code structure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message