hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-5239) Eliminate unused imports checkstyle warnings
Date Sat, 11 Jun 2016 04:31:21 GMT

    [ https://issues.apache.org/jira/browse/YARN-5239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15325708#comment-15325708
] 

Varun Saxena edited comment on YARN-5239 at 6/11/16 4:30 AM:
-------------------------------------------------------------

I had to tried to fix these earlier.
As the report shows, javadoc gets introduces if we write out fully qualified package name
and break it across multiple lines.
If we do not break it, more than 80 lines checkstyle issues comes in. So unused import gets
replaced by that.

I guess we will have to live with these checkstyle issues (of unused import). It is basically
a bug of checkstyle that it incorrectly points these out as unused imports.


was (Author: varun_saxena):
I had to tried to fix these earlier.
As the report shows, javadoc gets introduces if we git fully qualified package name and break
it across multiple lines.
If we do not break it, more than 80 lines checkstyle issues comes in. So unused import gets
replaced by that.

I guess we will have to live with these checkstyle issues (of unused import). It is basically
a bug of checkstyle that it incorrectly points these out as unused imports.

> Eliminate unused imports checkstyle warnings
> --------------------------------------------
>
>                 Key: YARN-5239
>                 URL: https://issues.apache.org/jira/browse/YARN-5239
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Joep Rottinghuis
>            Assignee: Joep Rottinghuis
>            Priority: Trivial
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-5239-YARN-2928.01.patch
>
>
> There are ~8 existing checkstyle issues generated due to unused imports.
> By fully qualifying the classes in javadoc and manually wrapping the javadoc under 80
characters we can eliminate these warnings.
> This will help with the eventual merge because then we introduce 8 fewer checkstyle warnings.
> The only checkstyle warnings left are now too many arguments, which cannot be easily
refactored w/o changing code structure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message