hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Junping Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5200) Improve yarn logs to get Container List
Date Thu, 16 Jun 2016 15:44:05 GMT

    [ https://issues.apache.org/jira/browse/YARN-5200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15334023#comment-15334023
] 

Junping Du commented on YARN-5200:
----------------------------------

Thanks [~xgong] for contributing the patch. A few comments:
1. I assume "-show_meta_info" is something we just add recently and not show up in any hadoop
releases yet (otherwise, it could be a incompatible change here). If so, "-show_container_info"
is better change to "-show_container_log_info" as it is not meta data for container but meta
data for container logs. The same as {{SHOW_CONTAINER_INFO}}.

2. {{private int showContainerLists()}} is better to update to showContainersList() which
consistent with other methods' name.

3. Can we combine two container report loop (to filter specific node id and container id)
in filterContainersInfo()?



> Improve yarn logs to get Container List
> ---------------------------------------
>
>                 Key: YARN-5200
>                 URL: https://issues.apache.org/jira/browse/YARN-5200
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-5200.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message