hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-5198) LogReader not closed in AHSWebServices and FileInputStream not closed in NMWebServices while reading container logs
Date Sat, 04 Jun 2016 17:52:59 GMT

    [ https://issues.apache.org/jira/browse/YARN-5198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315522#comment-15315522
] 

Varun Saxena edited comment on YARN-5198 at 6/4/16 5:52 PM:
------------------------------------------------------------

While looking at the code added with regards to log tooling enhancement, found that we haven't
closed LogReader in AHSWebServices#getStreamingOutput.
This would lead to connections with datanode stuck in CLOSE_WAIT state and may eventually
lead to too many open files error.

Moreover, in NMWebServices#getLogs we do not close FileInputStream. This is not a very big
issue as FileInputStream has finalize method which would close the input stream. But this
would mean that the corresponding FDs' will be hanging around till next cycle of GC happens.
This can be fixed as well.


was (Author: varun_saxena):
While looking at the code added with regards to log tooling enhancement. Found that we haven't
closed LogReader in AHSWebServices#getStreamingOutput.
This would lead to connections with datanode stuck in CLOSE_WAIT state and may eventually
lead to too many open files error.

Moreover, in NMWebServices#getLogs we do not close FileInputStream. This is not a very big
issue as FileInputStream has finalize method which would close the input stream. But this
would mean that the corresponding FDs' will be hanging around till next cycle of GC happens.
This can be fixed as well although this seems to be a very old issue.

> LogReader not closed in AHSWebServices and FileInputStream not closed in NMWebServices
while reading container logs
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-5198
>                 URL: https://issues.apache.org/jira/browse/YARN-5198
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, timelineserver
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message