hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sangjin Lee (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5189) Make HBaseTimeline[Reader|Writer]Impl default and move FileSystemTimeline*Impl
Date Thu, 02 Jun 2016 20:06:59 GMT

    [ https://issues.apache.org/jira/browse/YARN-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15312964#comment-15312964
] 

Sangjin Lee commented on YARN-5189:
-----------------------------------

Thanks for updating the patch [~jrottinghuis]! I think it's pretty close. Some additional
comments.

- Adding some comments in the javadoc for {{FileSystemTimelineReader/WriterImpl}} to the effect
that these are for testing purposes might be good
- Although good changes, changes that clean up whitespace are causing the diffs to become
bigger, and may be tricky to merge/rebase, especially on {{YarnConfiguration.java}}. If you
don't mind, I'll back out the whitespace changes and repost the patch.
- tabs in {{yarn-default.xml}}; will also fix them

(TimelineMREventHandling.java)
- the code that sets the writer should be in {{testMRNewTimelineServiceEventHandling()}} than
the current location; that will fix the unit test

I'm going to upload a patch that does the above except for the javadoc comments so that we
can verify it with jenkins.

> Make HBaseTimeline[Reader|Writer]Impl default and move FileSystemTimeline*Impl
> ------------------------------------------------------------------------------
>
>                 Key: YARN-5189
>                 URL: https://issues.apache.org/jira/browse/YARN-5189
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Joep Rottinghuis
>            Assignee: Joep Rottinghuis
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-5189-YARN-2928.01.patch, YARN-5189-YARN-2928.02.patch, YARN-5189-YARN-2928.03.patch,
YARN-5189-YARN-2928.04.patch
>
>
> [~naganarasimha_gr@apache.org] questioned whether it made sense to default to an implementation
that doesn't support all functionality.
> [~sjlee0] opened YARN-5174 to track updating the documentation for ATS to reflect the
default shifting to the fully functional HBase implementation.
> It makes sense to remove a partial implementation, but on the other hand it is still
handing in testing. Hence this jira to move the file based implementations to the test package
and to make the HBase impls the default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message