hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sangjin Lee (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5189) Make HBaseTimeline[Reader|Writer]Impl default and move FileSystemTimeline*Impl
Date Thu, 02 Jun 2016 06:10:59 GMT

    [ https://issues.apache.org/jira/browse/YARN-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311806#comment-15311806
] 

Sangjin Lee commented on YARN-5189:
-----------------------------------

{quote}
Do you mean we should actually have the name of the Impl class in YarnConfiguration.java or
just a property in yarn-default that matches the property names as defined in YarnConfiguration.java?
{quote}
As you mentioned, the code defaulting is happening in {{TimelineCollectorManager}} and {{TimelineReaderServer}}.
I think it might be sufficient to add the defaults in {{yarn-default.xml}} then. Thoughts?

Also, {{TIMELINE_SERVICE_ENTITYFILE_FS_SUPPORT_APPEND}} is not the timeline service v.2 config,
so that's out of scope for this JIRA.

{quote}
I'm also wondering if we should further clarify in documentation and in the description of
yarn-default.xml that some properties are specific to the HBaseWriterImpl (for example yarn.timeline-service.coprocessor.app-final-value-retention-milliseconds)
and that others are more generic?
{quote}
How about renaming configuration properties that are specific to the HBase store to have "hbase"
in them? For example, we could do "yarn.timeline-service.coprocessor.app-final-value-retention-milliseconds"
to "yarn.timeline-service.hbase.coprocessor.app-final-value-retention-milliseconds".

> Make HBaseTimeline[Reader|Writer]Impl default and move FileSystemTimeline*Impl
> ------------------------------------------------------------------------------
>
>                 Key: YARN-5189
>                 URL: https://issues.apache.org/jira/browse/YARN-5189
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Joep Rottinghuis
>            Assignee: Joep Rottinghuis
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-5189-YARN-2928.01.patch, YARN-5189-YARN-2928.02.patch
>
>
> [~naganarasimha_gr@apache.org] questioned whether it made sense to default to an implementation
that doesn't support all functionality.
> [~sjlee0] opened YARN-5174 to track updating the documentation for ATS to reflect the
default shifting to the fully functional HBase implementation.
> It makes sense to remove a partial implementation, but on the other hand it is still
handing in testing. Hence this jira to move the file based implementations to the test package
and to make the HBase impls the default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message