hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carlo Curino (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5124) Modify AMRMClient to set the ExecutionType in the ResourceRequest
Date Tue, 07 Jun 2016 17:52:21 GMT

    [ https://issues.apache.org/jira/browse/YARN-5124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15319002#comment-15319002
] 

Carlo Curino commented on YARN-5124:
------------------------------------

[~asuresh] I see what you tried to do with the typedefs like {{class ExecutionTypeMap extends
HashMap<ExecutionType, CapabilityMap>}}. This is not what I was after with my comment,
and 
to the best of my understanding not very java as a coding style. 

I think the code structure would be much cleaner if you wrap the entire stack of maps of maps
you have in a separate class, so that you can make the physical representation independent

from the logical functionality, and delegate to that class much of the accesses etc.. This
would also move the 4-way for loops in a class that is only handling the data representation
and 
making the {{AMRMClientImpl}} a little simpler. 

> Modify AMRMClient to set the ExecutionType in the ResourceRequest
> -----------------------------------------------------------------
>
>                 Key: YARN-5124
>                 URL: https://issues.apache.org/jira/browse/YARN-5124
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: YARN-5124.001.patch, YARN-5124.002.patch, YARN-5124.003.patch, YARN-5124.004.patch,
YARN-5124.005.patch, YARN-5124.006.patch, YARN-5124.008.patch, YARN-5124.009.patch, YARN-5124.010.patch,
YARN-5124.011.patch, YARN-5124_YARN-5180_combined.007.patch, YARN-5124_YARN-5180_combined.008.patch
>
>
> Currently the {{ContainerRequest}} allows the AM to set the {{ExecutionType}} in the
AMRMClient, but it is not being set in the actual {{ResourceRequest}} that is sent to the
RM 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message