Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 26 May 2016 00:07:12 +0000 (UTC)
From: "Karthik Kambatla (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12972255.1464053493000.296877.1464221232835@Atlassian.JIRA>
In-Reply-To: <JIRA.12972255.1464053493000@Atlassian.JIRA>
References: <JIRA.12972255.1464053493000@Atlassian.JIRA> <JIRA.12972255.1464053493144@arcas>
Subject: [jira] [Comment Edited] (YARN-5132) Exclude generated protobuf
 sources from YARN Javadoc build
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 26 May 2016 00:07:15 -0000


    [ https://issues.apache.org/jira/browse/YARN-5132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301173#comment-15301173 ] 

Karthik Kambatla edited comment on YARN-5132 at 5/26/16 12:06 AM:
------------------------------------------------------------------

I see several reasons to get this in:
# As Subru, Chris and others mentioned, I don't see why we should publish javadocs of these proto generated classes. We should actually update the release script to remove javadoc from proto files. [~vinodkv], [~leftnoteasy] - you have been working on the releases recently, do we publish javadocs for these? 
# All JIRAs see these javadoc errors. It is painstakingly hard to figure out what javadoc issues the patch introduces. 


was (Author: kasha):
I see several reasons to get this in:
# As Subru, Chris and others mentioned, I don't see why we should publish javadocs of these proto generated classes. We should actually update the release script to remove javadoc from proto files. [~vinodkv], [~leftnoteasy] - you have been working on the releases recently, do we publish javadocs for these? 
# All JIRAs see these javadoc errors. It is painstakingly hard to figure out what javadoc issues the patch introduces. The example I ran into YARN-5035. 

> Exclude generated protobuf sources from YARN Javadoc build
> ----------------------------------------------------------
>
>                 Key: YARN-5132
>                 URL: https://issues.apache.org/jira/browse/YARN-5132
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Subru Krishnan
>            Assignee: Subru Krishnan
>            Priority: Critical
>         Attachments: YARN-5132-v1.patch
>
>
> Currently YARN build includes Javadoc from generated protobuf sources which is causing CI to fail. This JIRA proposes to exclude generated protobuf sources from YARN Javadoc build


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org