Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A2C2F2009F9 for ; Mon, 23 May 2016 19:44:16 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A1611160A05; Mon, 23 May 2016 17:44:16 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EE4DC160A2C for ; Mon, 23 May 2016 19:44:15 +0200 (CEST) Received: (qmail 97675 invoked by uid 500); 23 May 2016 17:44:15 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 97245 invoked by uid 99); 23 May 2016 17:44:14 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 May 2016 17:44:14 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id A0B882C1F70 for ; Mon, 23 May 2016 17:44:14 +0000 (UTC) Date: Mon, 23 May 2016 17:44:14 +0000 (UTC) From: "Li Lu (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-5094) some YARN container events have timestamp of -1 in REST output MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 23 May 2016 17:44:16 -0000 [ https://issues.apache.org/jira/browse/YARN-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15296707#comment-15296707 ] Li Lu commented on YARN-5094: ----------------------------- bq. We can either populate the timestamp in ContainerEvent/ApplicationEvent/LocalizationEvent or take current system time and populate the timestamp in publish***Event methods(or other publish methods) in NMTimelinePublisher as these are direct calls from ContainerManagerImpl/ContainersMonitorImpl. Yes. I'm relatively conservative on the first approach, since there are notes in AbstractEvent saying that: {code} // We're not generating a real timestamp here. It's too expensive. {code} Having seen this and also the SMP design in RM I think passing in timestamp would be a better approach? > some YARN container events have timestamp of -1 in REST output > -------------------------------------------------------------- > > Key: YARN-5094 > URL: https://issues.apache.org/jira/browse/YARN-5094 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver > Affects Versions: YARN-2928 > Reporter: Sangjin Lee > Assignee: Li Lu > Labels: yarn-2928-1st-milestone > > Some events in the YARN container entities have timestamp of -1. The RM-generated container events have proper timestamps. It appears that it's the NM-generated events that have -1: YARN_CONTAINER_CREATED, YARN_CONTAINER_FINISHED, YARN_NM_CONTAINER_LOCALIZATION_FINISHED, YARN_NM_CONTAINER_LOCALIZATION_STARTED. > In the YARN container page, > {noformat} > { > id: "YARN_CONTAINER_CREATED", > timestamp: -1, > info: { } > }, > { > id: "YARN_CONTAINER_FINISHED", > timestamp: -1, > info: { > YARN_CONTAINER_EXIT_STATUS: 0, > YARN_CONTAINER_STATE: "RUNNING", > YARN_CONTAINER_DIAGNOSTICS_INFO: "" > } > }, > { > id: "YARN_NM_CONTAINER_LOCALIZATION_FINISHED", > timestamp: -1, > info: { } > }, > { > id: "YARN_NM_CONTAINER_LOCALIZATION_STARTED", > timestamp: -1, > info: { } > } > {noformat} > I think the data itself is OK, but the values are not being populated in the REST output? -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org