Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 30 May 2016 21:16:13 +0000 (UTC)
From: "Karthik Kambatla (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12951356.1458251917000.333084.1464642973053@Atlassian.JIRA>
In-Reply-To: <JIRA.12951356.1458251917000@Atlassian.JIRA>
References: <JIRA.12951356.1458251917000@Atlassian.JIRA> <JIRA.12951356.1458251917119@arcas>
Subject: [jira] [Commented] (YARN-4837) User facing aspects of 'AM
 blacklisting' feature need fixing
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 30 May 2016 21:16:15 -0000


    [ https://issues.apache.org/jira/browse/YARN-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15306956#comment-15306956 ] 

Karthik Kambatla commented on YARN-4837:
----------------------------------------

Thanks for working on this, Vinod. Quickly skimmed through the patch. It is definitely more maintainable, thanks again for the cleanup. 

Just one nit:

RMAppAttemptImpl#shouldCountTowardsNodeBlacklisting: For ContainerExitStatus.DISKS_FAILED, doesn't that mean at least one disk failed? And, the NM can continue running with remaining disks right? Is the idea that even if we schedule it to the same node, the NM wouldn't give the same local directory? If yes, should we clarify the comment accordingly? 


> User facing aspects of 'AM blacklisting' feature need fixing
> ------------------------------------------------------------
>
>                 Key: YARN-4837
>                 URL: https://issues.apache.org/jira/browse/YARN-4837
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Vinod Kumar Vavilapalli
>            Priority: Critical
>         Attachments: YARN-4837-20160515.txt, YARN-4837-20160520.1.txt, YARN-4837-20160520.txt, YARN-4837-20160527.txt
>
>
> Was reviewing the user-facing aspects that we are releasing as part of 2.8.0.
> Looking at the 'AM blacklisting feature', I see several things to be fixed before we release it in 2.8.0.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org