hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5077) Fix FSLeafQueue#getFairShare() for queues with weight 0.0
Date Wed, 25 May 2016 13:51:12 GMT

    [ https://issues.apache.org/jira/browse/YARN-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300076#comment-15300076
] 

Karthik Kambatla commented on YARN-5077:
----------------------------------------

Actually, one last nit. Sorry for not suggesting this earlier. 

In ComputeFairShares#computeShare, if forceWeightOne is set, I don't see the need to check
the weights. Also, it can be simplified with a ternary operator. And, we can drop the comments
as well. 
{code}
float weight = forceWeightOne ? 1 : sched.getWeights().getWeight(type);
{code}

> Fix FSLeafQueue#getFairShare() for queues with weight 0.0
> ---------------------------------------------------------
>
>                 Key: YARN-5077
>                 URL: https://issues.apache.org/jira/browse/YARN-5077
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Yufei Gu
>            Assignee: Karthik Kambatla
>         Attachments: YARN-5077.001.patch, YARN-5077.002.patch, YARN-5077.003.patch, YARN-5077.004.patch
>
>
> 1) When a queue's weight is set to 0.0, FSLeafQueue#getFairShare() returns <memory:0,
vCores:0> 
> 2) When a queue's weight is nonzero, FSLeafQueue#getFairShare() returns <memory:16384,
vCores:8>
> In case 1), that means no container ever gets allocated for an AM because from the viewpoint
of the RM, there is never any headroom to allocate a container on that queue.
> For example, we have a pool with the following weights: 
> - root.dev 0.0 
> - root.product 1.0
> The root.dev is a best effort pool and should only get resources if root.product is not
running. In our tests, with no jobs running under root.product, jobs started in root.dev queue
stay stuck in ACCEPT phase and never start.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message