hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yongjun Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5048) DelegationTokenRenewer#skipTokenRenewal may throw NPE
Date Fri, 06 May 2016 06:14:13 GMT

    [ https://issues.apache.org/jira/browse/YARN-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273680#comment-15273680
] 

Yongjun Zhang commented on YARN-5048:
-------------------------------------

Thanks [~jianhe].

Noticed one little thing, we need to move {{@SuppressWarnings("unchecked")}} to right before
the code you added, as
{code}
    @SuppressWarnings("unchecked")
    AbstractDelegationTokenIdentifier identifier =
        ((Token<AbstractDelegationTokenIdentifier>) token).decodeIdentifier();
    if (identifier == null) {
      return false;
    }   
{code}

 +1 after that.

BTW, I wonder why our build system doesn't point that out as a warning.







> DelegationTokenRenewer#skipTokenRenewal may throw NPE 
> ------------------------------------------------------
>
>                 Key: YARN-5048
>                 URL: https://issues.apache.org/jira/browse/YARN-5048
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: YARN-5048.1.patch
>
>
> {{((Token<AbstractDelegationTokenIdentifier>)token).decodeIdentifier()}} may throw
NPE if RM does not have the corresponding toke kind class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message