hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5047) Refactor nodeUpdate across schedulers
Date Fri, 20 May 2016 20:41:12 GMT

    [ https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294147#comment-15294147
] 

Wangda Tan commented on YARN-5047:
----------------------------------

Thanks [~rchiang],

I have a similar comment which is mentioned by [~kasha]:
Now we have nodeUpdate and nodeUpdateInternal, which is a little confusing to me. Basically
we have two choices:
1) Leave nodeUpdate only, and sub classes can override it.
2) Keep both of nodeUpdate and nodeUpdateInternal, make nodeUpdate cannot be overriden

Personally I would prefer #1, I'm not sure if we really need to call nodeUpdateInternal *inside
nodeUpdate*.

Beyond comments from [~kasha], rest part of the patch looks good to me.

> Refactor nodeUpdate across schedulers
> -------------------------------------
>
>                 Key: YARN-5047
>                 URL: https://issues.apache.org/jira/browse/YARN-5047
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler, fairscheduler, scheduler
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Ray Chiang
>            Assignee: Ray Chiang
>         Attachments: YARN-5047.001.patch, YARN-5047.002.patch
>
>
> FairScheduler#nodeUpdate() and CapacityScheduler#nodeUpdate() have a lot of commonality
in their code.  See about refactoring the common parts into AbstractYARNScheduler.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message