hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andras Bokor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4994) Use MiniYARNCluster with try-with-resources in tests
Date Mon, 02 May 2016 20:33:12 GMT

    [ https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267449#comment-15267449
] 

Andras Bokor commented on YARN-4994:
------------------------------------

Hi [~jzhuge],

Thanks a lot for deep reviewing my patch. Tomorrow I will do the recommended changes. Until
I have some questions that will help my work:
bq. 45, 62, 91: javac errors, switch to non-deprecated constructor?
I noticed that and I am planning to solve this situation. Even if I change the called constructor
from test, inside MiniYarnCluster we still call the deprecated constructor from the other
constructors. So at the end we call deprecated method.
Last week I created a new JIRA ticket to follow up this. Please check [YARN-5007|https://issues.apache.org/jira/browse/YARN-5007].
Is it fine with you if I resolve it with the ticket I linked?

Second and more important:
I compared the test results what was posted by [~hadoopqa]. More or less the same tests are
failing so it seems they are not intermittent.
Do you have idea what can cause this? The changes should not be related. Most of them fail
with timeout. Other failures are happening in classes that was not changed. So it doesn't
really make sense.Do you have idea? Locally they do not fail.

> Use MiniYARNCluster with try-with-resources in tests
> ----------------------------------------------------
>
>                 Key: YARN-4994
>                 URL: https://issues.apache.org/jira/browse/YARN-4994
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 2.7.0
>            Reporter: Andras Bokor
>            Assignee: Andras Bokor
>            Priority: Trivial
>             Fix For: 2.7.0
>
>         Attachments: HDFS-10287.01.patch, HDFS-10287.02.patch, HDFS-10287.03.patch
>
>
> In tests MiniYARNCluster is used with the following pattern:
> In try-catch block create a MiniYARNCluster instance and in finally block close it.
> [Try-with-resources|https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html]
is preferred since Java7 instead of the pattern above.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message