hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andras Bokor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4994) Use MiniYARNCluster with try-with-resources in tests
Date Thu, 05 May 2016 20:57:13 GMT

    [ https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273076#comment-15273076
] 

Andras Bokor commented on YARN-4994:
------------------------------------

It seems the test failures are not related.
I thought Hadoop QA runs all the tests on every patch. Actually, it does not, so when I added
just some files the tests in org.apache.hadoop.yarn package did not run. That is why I did
not see tests failure in some cases and I saw when I added particular changes.
You can check YARN-5034:YARN-5034.13.patch. I changed only a comment and the same tests failed.
Can I consider as the test failures are not related?
If so, I will do the suggested changes and update the new patch tomorrow.

> Use MiniYARNCluster with try-with-resources in tests
> ----------------------------------------------------
>
>                 Key: YARN-4994
>                 URL: https://issues.apache.org/jira/browse/YARN-4994
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 2.7.0
>            Reporter: Andras Bokor
>            Assignee: Andras Bokor
>            Priority: Trivial
>             Fix For: 2.7.0
>
>         Attachments: HDFS-10287.01.patch, HDFS-10287.02.patch, HDFS-10287.03.patch
>
>
> In tests MiniYARNCluster is used with the following pattern:
> In try-catch block create a MiniYARNCluster instance and in finally block close it.
> [Try-with-resources|https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html]
is preferred since Java7 instead of the pattern above.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message