hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Li Lu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4412) Create ClusterMonitor to compute ordered list of preferred NMs for OPPORTUNITIC containers
Date Mon, 16 May 2016 23:23:12 GMT

    [ https://issues.apache.org/jira/browse/YARN-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285628#comment-15285628
] 

Li Lu commented on YARN-4412:
-----------------------------

bq. The checkstyle issues, most of which was caused by indentation errors have been corrected
in YARN-2888
I briefly scanned through the checkstyle report and the first several lines are not about
indentation errors: 
{code}
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:341:
 /** K least loaded nodes to be provided to the LocalScheduler of a: First sentence should
end with a period.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:347:
 /** Frequency for computing Top K Best Nodes */: First sentence should end with a period.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:352:
 /** Comparator for determining Node Load for Distributed Scheduling */: First sentence should
end with a period.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/records/impl/pb/NodeStatusPBImpl.java:417:
 public void setQueuedContainersStatus(QueuedContainersStatus queuedContainersStatus) {: Line
is longer than 80 characters (found 88).
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/records/impl/pb/NodeStatusPBImpl.java:460:
 private YarnProtos.ResourceUtilizationProto convertToProtoFormat(ResourceUtilization r) {:
Line is longer than 80 characters (found 91).
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/records/impl/pb/NodeStatusPBImpl.java:469:
 private YarnServerCommonProtos.QueuedContainersStatusProto convertToProtoFormat(: Line is
longer than 80 characters (found 82).
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/records/impl/pb/QueuedContainersStatusPBImpl.java:24:public
class QueuedContainersStatusPBImpl extends QueuedContainersStatus {: Missing a Javadoc comment.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/records/impl/pb/QueuedContainersStatusPBImpl.java:28:
 private YarnServerCommonProtos.QueuedContainersStatusProto.Builder builder = null;: Line
is longer than 80 characters (found 84).
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java:86:import
org.apache.hadoop.yarn.server.nodemanager.containermanager.queuing:6: Unused import - 
{code}

Most of them sound like real style issues. I haven't gone through the whole list, but personally
I'd treat -1s from Jenkins as committer -1s unless there are good reasons to justify. 

> Create ClusterMonitor to compute ordered list of preferred NMs for OPPORTUNITIC containers
> ------------------------------------------------------------------------------------------
>
>                 Key: YARN-4412
>                 URL: https://issues.apache.org/jira/browse/YARN-4412
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>             Fix For: 3.0.0-alpha1
>
>         Attachments: YARN-4412-yarn-2877.v1.patch, YARN-4412-yarn-2877.v2.patch, YARN-4412-yarn-2877.v3.patch,
YARN-4412-yarn-2877.v4.patch, YARN-4412-yarn-2877.v5.patch, YARN-4412-yarn-2877.v6.patch,
YARN-4412.007.patch, YARN-4412.008.patch, YARN-4412.009.patch, YARN-4412.find-bugs.patch
>
>
> Introduce a Cluster Monitor that aggregates load information from individual Node Managers
and computes an ordered list of preferred Node managers to be used as target Nodes for OPPORTUNISTIC
container allocations. 
> This list can be pushed out to the Node Manager (specifically the AMRMProxy running on
the Node) via the Allocate Response. This will be used to make local Scheduling decisions



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message