hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4325) Purge app state from NM state-store should cover more LOG_HANDLING cases
Date Fri, 06 May 2016 15:24:13 GMT

    [ https://issues.apache.org/jira/browse/YARN-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274198#comment-15274198
] 

Jason Lowe commented on YARN-4325:
----------------------------------

Thanks for the patch!

For AppCompletelyDoneTransition it seems a little odd that we fire off a log event then remove
the app that goes with that event.  I would expect we would either wait for the log finished/failed
event and cleanup in the FINISHED state like we normally do or not send the log event at all
since we already know it is failed/done.  Is the better fix to have the log aggregators properly
return a log failed event in these cases?

> Purge app state from NM state-store should cover more LOG_HANDLING cases
> ------------------------------------------------------------------------
>
>                 Key: YARN-4325
>                 URL: https://issues.apache.org/jira/browse/YARN-4325
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Critical
>         Attachments: ApplicationImpl.PNG, YARN-4325-v1.1.patch, YARN-4325-v1.patch, YARN-4325.patch
>
>
> From a long running cluster, we found tens of thousands of stale apps still be recovered
in NM restart recovery. 
> After investigating, there are three issues cause app state leak in NM state-store:
> 1. APPLICATION_LOG_HANDLING_FAILED is not handled with remove App in NMStateStore.
> 2. APPLICATION_LOG_HANDLING_FAILED event is missing in sent when hit aggregator's doAppLogAggregation()
exception case.
> 3. Only Application in FINISHED status receiving APPLICATION_LOG_FINISHED has transition
to remove app in NM state store. Application in other status - like APPLICATION_RESOURCES_CLEANUP
will ignore the event and later forget to remove this app from NM state store even after app
get finished.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message