Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DB01119451 for ; Tue, 26 Apr 2016 18:47:17 +0000 (UTC) Received: (qmail 63833 invoked by uid 500); 26 Apr 2016 18:47:16 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 63778 invoked by uid 500); 26 Apr 2016 18:47:16 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 63530 invoked by uid 99); 26 Apr 2016 18:47:16 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Apr 2016 18:47:16 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 127CB2C1F68 for ; Tue, 26 Apr 2016 18:47:13 +0000 (UTC) Date: Tue, 26 Apr 2016 18:47:13 +0000 (UTC) From: "Hadoop QA (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-4994) Use MiniYARNCluster with try-with-resources in tests MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-4994?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D15258= 678#comment-15258678 ]=20 Hadoop QA commented on YARN-4994: --------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 17s = {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m= 0s {color} | {color:green} The patch does not contain any @author tags. {c= olor} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green}= 0m 0s {color} | {color:green} The patch appears to include 7 new or modifi= ed test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 40s = {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 7m 42s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m= 0s {color} | {color:green} trunk passed with JDK v1.8.0_92 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m= 56s {color} | {color:green} trunk passed with JDK v1.7.0_95 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 1m 16s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m= 39s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}= 0m 55s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2= m 15s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m= 7s {color} | {color:green} trunk passed with JDK v1.8.0_92 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m= 5s {color} | {color:green} trunk passed with JDK v1.7.0_95 {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 15s = {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 1m 19s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 10= m 21s {color} | {color:green} the patch passed with JDK v1.8.0_92 {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 11m 55s {c= olor} | {color:red} root-jdk1.8.0_92 with JDK v1.8.0_92 generated 3 new + 7= 36 unchanged - 3 fixed =3D 739 total (was 739) {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 10m = 21s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 10= m 7s {color} | {color:green} the patch passed with JDK v1.7.0_95 {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 22m 2s {co= lor} | {color:red} root-jdk1.7.0_95 with JDK v1.7.0_95 generated 3 new + 73= 3 unchanged - 3 fixed =3D 736 total (was 736) {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 10m = 7s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 1m 24s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m= 4s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}= 1m 8s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green}= 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3= m 44s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m= 31s {color} | {color:green} the patch passed with JDK v1.8.0_92 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m= 23s {color} | {color:green} the patch passed with JDK v1.7.0_95 {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 26s {col= or} | {color:red} hadoop-yarn-server-tests in the patch failed with JDK v1.= 8.0_92. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 66m 48s {co= lor} | {color:red} hadoop-yarn-client in the patch failed with JDK v1.8.0_9= 2. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 12m 16s {co= lor} | {color:red} hadoop-mapreduce-client-app in the patch failed with JDK= v1.8.0_92. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 6s= {color} | {color:green} hadoop-archive-logs in the patch passed with JDK v= 1.8.0_92. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 22s {col= or} | {color:red} hadoop-yarn-server-tests in the patch failed with JDK v1.= 7.0_95. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 66m 50s {co= lor} | {color:red} hadoop-yarn-client in the patch failed with JDK v1.7.0_9= 5. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 10m 7s {col= or} | {color:red} hadoop-mapreduce-client-app in the patch failed with JDK = v1.7.0_95. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 35= s {color} | {color:green} hadoop-archive-logs in the patch passed with JDK = v1.7.0_95. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green}= 0m 24s {color} | {color:green} Patch does not generate ASF License warning= s. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 242m 56s {co= lor} | {color:black} {color} | \\ \\ || Reason || Tests || | JDK v1.8.0_92 Failed junit tests | hadoop.yarn.server.TestContainerManage= rSecurity | | | hadoop.yarn.server.TestMiniYarnClusterNodeUtilization | | | hadoop.yarn.client.TestGetGroups | | | hadoop.yarn.client.api.impl.TestAMRMProxy | | | hadoop.mapreduce.v2.app.job.impl.TestTaskAttempt | | JDK v1.8.0_92 Timed out junit tests | org.apache.hadoop.yarn.client.cli.T= estYarnCLI | | | org.apache.hadoop.yarn.client.api.impl.TestYarnClient | | | org.apache.hadoop.yarn.client.api.impl.TestAMRMClient | | | org.apache.hadoop.yarn.client.api.impl.TestNMClient | | JDK v1.7.0_95 Failed junit tests | hadoop.yarn.server.TestContainerManage= rSecurity | | | hadoop.yarn.server.TestMiniYarnClusterNodeUtilization | | | hadoop.yarn.client.TestGetGroups | | | hadoop.yarn.client.api.impl.TestAMRMProxy | | | hadoop.mapreduce.v2.app.job.impl.TestJobImpl | | JDK v1.7.0_95 Timed out junit tests | org.apache.hadoop.yarn.client.cli.T= estYarnCLI | | | org.apache.hadoop.yarn.client.api.impl.TestYarnClient | | | org.apache.hadoop.yarn.client.api.impl.TestAMRMClient | | | org.apache.hadoop.yarn.client.api.impl.TestNMClient | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:fbe3e86 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/1280075= 3/HDFS-10287.01.patch | | JIRA Issue | YARN-4994 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsit= e unit findbugs checkstyle | | uname | Linux 3e286eb9fc0f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT We= d Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provide= d.sh | | git revision | trunk / 1a3f148 | | Default Java | 1.7.0_95 | | Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/ja= va-7-openjdk-amd64:1.7.0_95 | | findbugs | v3.0.0 | | javac | root-jdk1.8.0_92: https://builds.apache.org/job/PreCommit-YARN-Bu= ild/11222/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_92.txt | | javac | root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-YARN-Bu= ild/11222/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/11222/artifact/= patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_= hadoop-yarn-server-tests-jdk1.8.0_92.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/11222/artifact/= patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-= jdk1.8.0_92.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/11222/artifact/= patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_ha= doop-mapreduce-client-app-jdk1.8.0_92.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/11222/artifact/= patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_= hadoop-yarn-server-tests-jdk1.7.0_95.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/11222/artifact/= patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-= jdk1.7.0_95.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/11222/artifact/= patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_ha= doop-mapreduce-client-app-jdk1.7.0_95.txt | | unit test logs | https://builds.apache.org/job/PreCommit-YARN-Build/1122= 2/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-y= arn-server_hadoop-yarn-server-tests-jdk1.8.0_92.txt https://builds.apache.o= rg/job/PreCommit-YARN-Build/11222/artifact/patchprocess/patch-unit-hadoop-y= arn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_92.txt https://builds.a= pache.org/job/PreCommit-YARN-Build/11222/artifact/patchprocess/patch-unit-h= adoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app= -jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-YARN-Build/11222/a= rtifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn= -server_hadoop-yarn-server-tests-jdk1.7.0_95.txt https://builds.apache.org/= job/PreCommit-YARN-Build/11222/artifact/patchprocess/patch-unit-hadoop-yarn= -project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_95.txt https://builds.apac= he.org/job/PreCommit-YARN-Build/11222/artifact/patchprocess/patch-unit-hado= op-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jd= k1.7.0_95.txt | | JDK v1.7.0_95 Test Results | https://builds.apache.org/job/PreCommit-YAR= N-Build/11222/testReport/ | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-y= arn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client had= oop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app = hadoop-tools/hadoop-archive-logs U: . | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/11222= /console | | Powered by | Apache Yetus 0.2.0 http://yetus.apache.org | This message was automatically generated. > Use MiniYARNCluster with try-with-resources in tests > ---------------------------------------------------- > > Key: YARN-4994 > URL: https://issues.apache.org/jira/browse/YARN-4994 > Project: Hadoop YARN > Issue Type: Improvement > Components: test > Affects Versions: 2.7.0 > Reporter: Andras Bokor > Assignee: Andras Bokor > Priority: Trivial > Fix For: 2.7.0 > > Attachments: HDFS-10287.01.patch > > > In tests MiniYARNCluster is used with the following pattern: > In try-catch block create a MiniYARNCluster instance and in finally block= close it. > [Try-with-resources|https://docs.oracle.com/javase/tutorial/essential/exc= eptions/tryResourceClose.html] is preferred since Java7 instead of the patt= ern above. -- This message was sent by Atlassian JIRA (v6.3.4#6332)