Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C5076193C1 for ; Wed, 6 Apr 2016 18:30:26 +0000 (UTC) Received: (qmail 57287 invoked by uid 500); 6 Apr 2016 18:30:26 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 57162 invoked by uid 500); 6 Apr 2016 18:30:26 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 56755 invoked by uid 99); 6 Apr 2016 18:30:26 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Apr 2016 18:30:26 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id DAA962C1F61 for ; Wed, 6 Apr 2016 18:30:25 +0000 (UTC) Date: Wed, 6 Apr 2016 18:30:25 +0000 (UTC) From: "Sunil G (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-4925) ContainerRequest in AMRMClient, application should be able to specify nodes/racks together with nodeLabelExpression MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-4925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228836#comment-15228836 ] Sunil G commented on YARN-4925: ------------------------------- Thanks [~Naganarasimha Garla] for the clarification. One final doubt, in this case if we change the labelExpression for ANY containerRequest , it will replace the expression set by node/rack local earlier. Correct. > ContainerRequest in AMRMClient, application should be able to specify nodes/racks together with nodeLabelExpression > ------------------------------------------------------------------------------------------------------------------- > > Key: YARN-4925 > URL: https://issues.apache.org/jira/browse/YARN-4925 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Bibin A Chundatt > Assignee: Bibin A Chundatt > > Currently with nodelabel AMRMClient will not be able to specify nodelabels with Node/Rack requests.For application like spark NODE_LOCAL requests cannot be asked with label expression. > As per the check in {{AMRMClientImpl#checkNodeLabelExpression}} > {noformat} > // Don't allow specify node label against ANY request > if ((containerRequest.getRacks() != null && > (!containerRequest.getRacks().isEmpty())) > || > (containerRequest.getNodes() != null && > (!containerRequest.getNodes().isEmpty()))) { > throw new InvalidContainerRequestException( > "Cannot specify node label with rack and node"); > } > {noformat} > {{AppSchedulingInfo#updateResourceRequests}} we do reset of labels to that of OFF-SWITCH. > The above check is not required for ContainerRequest ask /cc [~wangda] thank you for confirming -- This message was sent by Atlassian JIRA (v6.3.4#6332)