Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 648B31939F for ; Tue, 26 Apr 2016 18:32:13 +0000 (UTC) Received: (qmail 18585 invoked by uid 500); 26 Apr 2016 18:32:13 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 18541 invoked by uid 500); 26 Apr 2016 18:32:13 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 18503 invoked by uid 99); 26 Apr 2016 18:32:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Apr 2016 18:32:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 0924A2C1F6E for ; Tue, 26 Apr 2016 18:32:13 +0000 (UTC) Date: Tue, 26 Apr 2016 18:32:13 +0000 (UTC) From: "Wangda Tan (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258653#comment-15258653 ] Wangda Tan commented on YARN-4390: ---------------------------------- [~kasha], Thanks for comment, There're two different readers of schedulerNode, one is scheduler itself. Since all changes SchedulerNode needs scheduler's synchronized lock, so all reader of scheduler can get a consistent value. PreemptionPolicy can read inconsistent value in some cases, but that can be fixed in next runs because preemptionPolicy doesn't kill containers immediately. I will also try to run tests to see if it causes performance issue without the volatile changes. > Do surgical preemption based on reserved container in CapacityScheduler > ----------------------------------------------------------------------- > > Key: YARN-4390 > URL: https://issues.apache.org/jira/browse/YARN-4390 > Project: Hadoop YARN > Issue Type: Sub-task > Components: capacity scheduler > Affects Versions: 3.0.0, 2.8.0, 2.7.3 > Reporter: Eric Payne > Assignee: Wangda Tan > Attachments: YARN-4390-design.1.pdf, YARN-4390-test-results.pdf, YARN-4390.1.patch, YARN-4390.2.patch, YARN-4390.3.branch-2.patch, YARN-4390.3.patch, YARN-4390.4.patch, YARN-4390.5.patch, YARN-4390.6.patch > > > There are multiple reasons why preemption could unnecessarily preempt containers. One is that an app could be requesting a large container (say 8-GB), and the preemption monitor could conceivably preempt multiple containers (say 8, 1-GB containers) in order to fill the large container request. These smaller containers would then be rejected by the requesting AM and potentially given right back to the preempted app. -- This message was sent by Atlassian JIRA (v6.3.4#6332)