hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andras Bokor (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (YARN-4994) Use MiniYARNCluster with try-with-resources in tests
Date Wed, 27 Apr 2016 12:09:12 GMT

     [ https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andras Bokor updated YARN-4994:
-------------------------------
    Attachment: HDFS-10287.02.patch

[~templedf] Thanks a lot for reviewing my patch.
I updated the patch according to you recommendations. Some notes to the second point:
My IDE's settings was not in sync with Apache conventions. I set indent to 2 and set continuation
intend to 4.
[^HDFS-10287.02.patch]

> Use MiniYARNCluster with try-with-resources in tests
> ----------------------------------------------------
>
>                 Key: YARN-4994
>                 URL: https://issues.apache.org/jira/browse/YARN-4994
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 2.7.0
>            Reporter: Andras Bokor
>            Assignee: Andras Bokor
>            Priority: Trivial
>             Fix For: 2.7.0
>
>         Attachments: HDFS-10287.01.patch, HDFS-10287.02.patch
>
>
> In tests MiniYARNCluster is used with the following pattern:
> In try-catch block create a MiniYARNCluster instance and in finally block close it.
> [Try-with-resources|https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html]
is preferred since Java7 instead of the pattern above.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message