hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sangjin Lee (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4986) Add a check in the coprocessor for table to operated on
Date Fri, 29 Apr 2016 16:26:12 GMT

    [ https://issues.apache.org/jira/browse/YARN-4986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264291#comment-15264291
] 

Sangjin Lee commented on YARN-4986:
-----------------------------------

Thanks [~vrushalic] for finding and fixing these issues! It's an important fix.

The patch LGTM for the most part. Can we address the checkstyle issues as they are quite straightforward?

Also, one other minor issue: in FlowRunCoprocessor.java:79,81, let's wrap the {{debug()}}
calls with {{if (LOG.isDebugEnabled()}}.

> Add a check in the coprocessor for table to operated on
> -------------------------------------------------------
>
>                 Key: YARN-4986
>                 URL: https://issues.apache.org/jira/browse/YARN-4986
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Vrushali C
>            Assignee: Vrushali C
>         Attachments: YARN-4986-YARN-2928.01.patch
>
>
> As a precautionary measure, it will be a good idea to have the coprocessor code check
which table it needs to be working on and return/proceed accordingly. This is more of a safety
check so that we are sure we are not inadvertently executing the coprocessor code on some
other table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message