hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Li Lu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4983) JVM and UGI metrics disappear after RM is once transitioned to standby mode
Date Mon, 25 Apr 2016 18:37:13 GMT

    [ https://issues.apache.org/jira/browse/YARN-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256754#comment-15256754
] 

Li Lu commented on YARN-4983:
-----------------------------

Thanks for the review [~djp]! I totally agree that we need to refactor the code of RM HA so
that the code is more maintainable. For the boolean flag here, {{initialize}} and {{fromActive}}
are currently decoupled. {{createAndInitActiveServices}} has two call sites, one in RM#serviceInit,
another in reinitialize. When reinitializing, we're using the flag {{initialize}} to distinguish
if we need to reinitialize the active service. This method is called when we do a state transition
to standby and active. Therefore, we only need to set fromActive to true when we're reinitializing
the active services and is transitioning from active to standby. Due to the amount of work
to refactor RM HA, maybe we want to resolve that in a separate JIRA? We can focus on a quick
fix for the current symptom in this JIRA? Thanks! 

BTW, I kicked another Jenkins run to see if there are any other UT problems. 

> JVM and UGI metrics disappear after RM is once transitioned to standby mode
> ---------------------------------------------------------------------------
>
>                 Key: YARN-4983
>                 URL: https://issues.apache.org/jira/browse/YARN-4983
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Li Lu
>            Assignee: Li Lu
>         Attachments: YARN-4983-trunk.000.patch, YARN-4983-trunk.001.patch, YARN-4983-trunk.002.patch
>
>
> When get transitioned to standby, the RM will shutdown the existing metric system and
relaunch a new one. This will cause the jvm metrics and ugi metrics to miss in the new metric
system. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message