hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Subru Krishnan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4957) Add getNewReservation in ApplicationClientProtocol
Date Thu, 21 Apr 2016 19:49:25 GMT

    [ https://issues.apache.org/jira/browse/YARN-4957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15252540#comment-15252540
] 

Subru Krishnan commented on YARN-4957:
--------------------------------------

Thanks [~seanpo03] for addressing my comments. The latest patch LGTM, +1 from my side.

Just a couple of minor comments on the documentation:
  * Move the part about getting reservationId to either a pre-step or step 0 as now text is
aligned with the diagram.
  * The link to the get new reservationId is broken.

[~curino], can you take a look?

> Add getNewReservation in ApplicationClientProtocol
> --------------------------------------------------
>
>                 Key: YARN-4957
>                 URL: https://issues.apache.org/jira/browse/YARN-4957
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: applications, client, resourcemanager
>    Affects Versions: 2.8.0
>            Reporter: Subru Krishnan
>            Assignee: Sean Po
>              Labels: api-breaking
>         Attachments: YARN-4957.v0.patch, YARN-4957.v1.patch, YARN-4957.v2.patch, YARN-4957.v3.patch,
YARN-4957.v4.patch
>
>
> Currently submitReservation returns a ReservationId if sucessful. This JIRA propose adding
a getNewReservation in ApplicationClientProtocol for the following reasons:
>   * Prevent zombie reservations in the face of client and/or network failures post submitReservation
>   * Align reservation submission with application submission



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message