hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Vasudev (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-4906) Capture container start/finish time in container metrics
Date Fri, 01 Apr 2016 14:27:25 GMT

    [ https://issues.apache.org/jira/browse/YARN-4906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221758#comment-15221758
] 

Varun Vasudev edited comment on YARN-4906 at 4/1/16 2:27 PM:
-------------------------------------------------------------

Thanks for the patch [~jianhe]. Few things -
# Do you think we should add a duration metric? For longer running containers, it would be
a useful metric. You'll have to use the MonotonicClock for that though.
# {code}
long unrgisterDelay = conf.getLong(
+          YarnConfiguration.NM_CONTAINER_METRICS_UNREGISTER_DELAY_MS,
+          YarnConfiguration.DEFAULT_NM_CONTAINER_METRICS_UNREGISTER_DELAY_MS);
{code}
Typo in the spelling of unregisterDelay
# The start time won't be preserved during a work preserving NM restart - this is also true
for the other statistical metrics like the histograms, and the advanced actual resource usage
metrics. I'm open to fixing this in a follow up JIRA.




was (Author: vvasudev):
Thanks for the patch [~jianhe]. Couple of things -
# Do you think we should add a duration metric? For longer running containers, it would be
a useful metric. You'll have to use the MonotonicClock for that though.
# {code}
long unrgisterDelay = conf.getLong(
+          YarnConfiguration.NM_CONTAINER_METRICS_UNREGISTER_DELAY_MS,
+          YarnConfiguration.DEFAULT_NM_CONTAINER_METRICS_UNREGISTER_DELAY_MS);
{code}
Typo in the spelling of unregisterDelay
# The start time won't be preserved during a work preserving NM restart - this is also true
for the other statistical metrics like the histograms, and the advanced actual resource usage
metrics. I'm open to fixing this in a follow up JIRA.



> Capture container start/finish time in container metrics
> --------------------------------------------------------
>
>                 Key: YARN-4906
>                 URL: https://issues.apache.org/jira/browse/YARN-4906
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: YARN-4906.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message