hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tao Jie (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4855) Should check if node exists when replace nodelabels
Date Thu, 07 Apr 2016 02:35:25 GMT

    [ https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229557#comment-15229557
] 

Tao Jie commented on YARN-4855:
-------------------------------

[~sunilg] [~leftnoteasy] [~naganarasimha] Thanks for your comments.
I agree "--fail-on-unkown-nodes" makes the option more clear.
{quote}
also one more aspect is does it require a protocol change can we do it in the client side
?
{quote}
When we do verification on client side, client should request for all active node list (if
verify on server side, node list is available in memory). My earlier concern is that it will
bring more load if we do this verification as default behavior. However when we keep the default
behavior as it used to be, and add one option for the node verification, I think on client
side is more concise.

More consideration´╝î
When we use *yarn rmadmin -replaceLabelsOnNode* and add node label to wrong nodes, this information
seems to leak on RM. It stores in RM memory/filesystem, but could not be found in website
or by shell cmd. As a result, it is difficult to remove or correct. Maybe it could be fixed
in another Jira.
Please correct me if I am wrong, thanks!


> Should check if node exists when replace nodelabels
> ---------------------------------------------------
>
>                 Key: YARN-4855
>                 URL: https://issues.apache.org/jira/browse/YARN-4855
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.6.0
>            Reporter: Tao Jie
>            Assignee: Tao Jie
>            Priority: Minor
>         Attachments: YARN-4855.001.patch
>
>
> Today when we add nodelabels to nodes, it would succeed even if nodes are not existing
NodeManger in cluster without any message.
> It could be like this:
> When we use *yarn rmadmin -replaceLabelsOnNode "node1=label1"*, it would be denied if
node does not exist.
> When we use *yarn rmadmin -replaceLabelsOnNode -force "node1=label1"* would add nodelabels
no matter whether node exists



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message