hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4808) SchedulerNode can use a few more cosmetic changes
Date Tue, 26 Apr 2016 12:54:13 GMT

    [ https://issues.apache.org/jira/browse/YARN-4808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258023#comment-15258023

Karthik Kambatla commented on YARN-4808:

I briefly looked at YARN-4390, and commented there. A couple of comments here:
# We don't really need the ResourceUtilization fields. Reading them from RMNode seems very
# I am comfortable leaving numContainers volatile. 

Actually, since SchedulerNode has more changes coming, may be I should close this as a duplicate
of YARN-4511?

> SchedulerNode can use a few more cosmetic changes
> -------------------------------------------------
>                 Key: YARN-4808
>                 URL: https://issues.apache.org/jira/browse/YARN-4808
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: scheduler
>    Affects Versions: 2.8.0
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: yarn-4808-1.patch, yarn-4808-2.patch
> We have made some cosmetic changes to SchedulerNode recently. While working on YARN-4511,
realized we could improve it a little more:
> # Remove volatile variables - don't see the need for them being volatile
> # Some methods end up doing very similar things, so consolidating them
> # Renaming totalResource to capacity. YARN-4511 plans to add inflatedCapacity to include
the un-utilized resources, and having two totals can be a little confusing. 

This message was sent by Atlassian JIRA

View raw message