hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Templeton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long
Date Tue, 19 Apr 2016 21:36:25 GMT

    [ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248714#comment-15248714
] 

Daniel Templeton commented on YARN-4807:
----------------------------------------

Thanks, [~yufeigu].  I just did one last thorough review of the full patch.  Here's my hopefully
last set of comments:

* MockRM.java:216 - spacing is off
* MockRM.java:303 - comment should be more specific
* MackRM.java:322 - exception (and preceeding comment) should be more specific
* MackRM.java:337 - exception (and preceeding comment) should be more specific
* MackRM.java:353 - exception (and preceeding comment) should be more specific
* TestAMRestart.java:831 - the comment should also explain why you're sleeping here
* TestAMRestart.java:877 - the comment should also explain why you're sleeping here
* TestApplicationMasterService.java:313 - the comment should also explain why you're sleeping
here
* TestRMApplicationHistoryWriter.java:449 - the comment should also explain why you're sleeping
here

> MockAM#waitForState sleep duration is too long
> ----------------------------------------------
>
>                 Key: YARN-4807
>                 URL: https://issues.apache.org/jira/browse/YARN-4807
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 2.8.0
>            Reporter: Karthik Kambatla
>            Assignee: Yufei Gu
>              Labels: newbie
>         Attachments: YARN-4807.001.patch, YARN-4807.002.patch, YARN-4807.003.patch, YARN-4807.004.patch,
YARN-4807.005.patch, YARN-4807.006.patch, YARN-4807.007.patch, YARN-4807.008.patch, YARN-4807.009.patch,
YARN-4807.010.patch, YARN-4807.011.patch, YARN-4807.012.patch
>
>
> MockAM#waitForState sleep duration (500 ms) is too long. Also, there is significant duplication
with MockRM#waitForState.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message