hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Templeton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long
Date Tue, 19 Apr 2016 17:00:29 GMT

    [ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248175#comment-15248175
] 

Daniel Templeton commented on YARN-4807:
----------------------------------------

Thanks, [~yufeigu]!  A quick skim of the patch looks good.  The loops look much better now.
 Unfortunately, I did just notice something that I should have caught before.  The throws
clauses on the {{waitForState()}} methods are needlessly general.  Some of them should just
be {{InterruptedException}}.  Can you please make them more specific and them update the javadocs
accordingly?

> MockAM#waitForState sleep duration is too long
> ----------------------------------------------
>
>                 Key: YARN-4807
>                 URL: https://issues.apache.org/jira/browse/YARN-4807
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 2.8.0
>            Reporter: Karthik Kambatla
>            Assignee: Yufei Gu
>              Labels: newbie
>         Attachments: YARN-4807.001.patch, YARN-4807.002.patch, YARN-4807.003.patch, YARN-4807.004.patch,
YARN-4807.005.patch, YARN-4807.006.patch, YARN-4807.007.patch, YARN-4807.008.patch, YARN-4807.009.patch,
YARN-4807.010.patch
>
>
> MockAM#waitForState sleep duration (500 ms) is too long. Also, there is significant duplication
with MockRM#waitForState.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message