hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunil G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4624) NPE in PartitionQueueCapacitiesInfo while accessing Schduler UI
Date Wed, 06 Apr 2016 15:43:25 GMT

    [ https://issues.apache.org/jira/browse/YARN-4624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228492#comment-15228492
] 

Sunil G commented on YARN-4624:
-------------------------------

I think this has gone stale. Lets move forward.

In YARN-4304, one of the small improvement was to hide {{maxAMPercentageLimit}} for parent
queue. We achieved this by declaring this variable as {{Float}} and was setting to null if
queue is ParentQueue. 

Now we have got this corner scenario when labels are available in cluster, and no label-mappings
are defined in CS. We have fixed partially in YARN-4634, however we can still have some more
cases like here. So ideally its better to handle  null check for {{getMaxAMPercentageLimit}}
from UI to keep the improvement what we have done as part of YARN-4304.

But after seeing the findbug warning, essentially we are boxing and unboxing this float variable.
And I could see that there are some other parrellel effort going on in other tickets to avoid
such cases.YARN-4630.

So I think we can still keep {{float}} and avoid this problem. But we will loose small part
of improvement there.  So I think may be we can group this new metrics (maxAMPercentageLimit
etc) in other DAO object and can use it. If its fine we can go with v1 patch here and unblock
the scheduler issue. And other improvement can be tracked separately. [~leftnoteasy], Could
you pls share your thoughts here.


> NPE in PartitionQueueCapacitiesInfo while accessing Schduler UI
> ---------------------------------------------------------------
>
>                 Key: YARN-4624
>                 URL: https://issues.apache.org/jira/browse/YARN-4624
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>         Attachments: SchedulerUIWithOutLabelMapping.png, YARN-2674-002.patch, YARN-4624-003.patch,
YARN-4624.patch
>
>
> Scenario:
> =======
> Configure nodelables and add to cluster
> Start the cluster
> {noformat}
> java.lang.NullPointerException
> 	at org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.PartitionQueueCapacitiesInfo.getMaxAMLimitPercentage(PartitionQueueCapacitiesInfo.java:114)
> 	at org.apache.hadoop.yarn.server.resourcemanager.webapp.CapacitySchedulerPage$LeafQueueInfoBlock.renderQueueCapacityInfo(CapacitySchedulerPage.java:163)
> 	at org.apache.hadoop.yarn.server.resourcemanager.webapp.CapacitySchedulerPage$LeafQueueInfoBlock.renderLeafQueueInfoWithPartition(CapacitySchedulerPage.java:105)
> 	at org.apache.hadoop.yarn.server.resourcemanager.webapp.CapacitySchedulerPage$LeafQueueInfoBlock.render(CapacitySchedulerPage.java:94)
> 	at org.apache.hadoop.yarn.webapp.view.HtmlBlock.render(HtmlBlock.java:69)
> 	at org.apache.hadoop.yarn.webapp.view.HtmlBlock.renderPartial(HtmlBlock.java:79)
> 	at org.apache.hadoop.yarn.webapp.View.render(View.java:235)
> 	at org.apache.hadoop.yarn.webapp.view.HtmlBlock$Block.subView(HtmlBlock.java:43)
> 	at org.apache.hadoop.yarn.webapp.hamlet.HamletImpl$EImp._v(HamletImpl.java:117)
> 	at org.apache.hadoop.yarn.webapp.hamlet.Hamlet$LI._(Hamlet.java:7702)
> 	at org.apache.hadoop.yarn.server.resourcemanager.webapp.CapacitySchedulerPage$QueueBlock.render(CapacitySchedulerPage.java:293)
> 	at org.apache.hadoop.yarn.webapp.view.HtmlBlock.render(HtmlBlock.java:69)
> 	at org.apache.hadoop.yarn.webapp.view.HtmlBlock.renderPartial(HtmlBlock.java:79)
> 	at org.apache.hadoop.yarn.webapp.View.render(View.java:235)
> 	at org.apache.hadoop.yarn.webapp.view.HtmlBlock$Block.subView(HtmlBlock.java:43)
> 	at org.apache.hadoop.yarn.webapp.hamlet.HamletImpl$EImp._v(HamletImpl.java:117)
> 	at org.apache.hadoop.yarn.webapp.hamlet.Hamlet$LI._(Hamlet.java:7702)
> 	at org.apache.hadoop.yarn.server.resourcemanager.webapp.CapacitySchedulerPage$QueuesBlock.render(CapacitySchedulerPage.java:447)
> 	at org.apache.hadoop.yarn.webapp.view.HtmlBlock.render(HtmlBlock.java:69)
> 	at org.apache.hadoop.yarn.webapp.view.HtmlBlock.renderPartial(HtmlBlock.java:79)
> 	at org.apache.hadoop.yarn.webapp.View.render(View.java:235)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message