hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4514) [YARN-3368] Cleanup hardcoded configurations, such as RM/ATS addresses
Date Fri, 15 Apr 2016 00:12:25 GMT

    [ https://issues.apache.org/jira/browse/YARN-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242185#comment-15242185
] 

Wangda Tan commented on YARN-4514:
----------------------------------

[~sunilg],

I tried to run the patch locally, it works fine for me.

Only one minor comment:
{code}
    /*
     * Local URL. This can be empty by default. For testbed if corsproxy is used,
     * corsproxy URL can be configured here. For eg:"localhost:1337"
     */
{code}

It could be more clear, such as:
"This *is* empty by default. ... Turn it on while RM/ATS running on the same host... etc..."

> [YARN-3368] Cleanup hardcoded configurations, such as RM/ATS addresses
> ----------------------------------------------------------------------
>
>                 Key: YARN-4514
>                 URL: https://issues.apache.org/jira/browse/YARN-4514
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wangda Tan
>            Assignee: Sunil G
>         Attachments: YARN-4514-YARN-3368.1.patch, YARN-4514-YARN-3368.2.patch, YARN-4514-YARN-3368.3.patch,
YARN-4514-YARN-3368.4.patch, YARN-4514-YARN-3368.5.patch, YARN-4514-YARN-3368.6.patch, YARN-4514-YARN-3368.7.patch
>
>
> We have several configurations are hard-coded, for example, RM/ATS addresses, we should
make them configurable. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message