Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 32A5E18CF1 for ; Tue, 29 Mar 2016 02:09:26 +0000 (UTC) Received: (qmail 26934 invoked by uid 500); 29 Mar 2016 02:09:25 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 26828 invoked by uid 500); 29 Mar 2016 02:09:25 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 26592 invoked by uid 99); 29 Mar 2016 02:09:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Mar 2016 02:09:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 8BBC92C1F60 for ; Tue, 29 Mar 2016 02:09:25 +0000 (UTC) Date: Tue, 29 Mar 2016 02:09:25 +0000 (UTC) From: "Rohith Sharma K S (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-4880) Running TestZKRMStateStorePerf with real zookeeper cluster throws NPE MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-4880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215265#comment-15215265 ] Rohith Sharma K S commented on YARN-4880: ----------------------------------------- Sure, go ahead:-) > Running TestZKRMStateStorePerf with real zookeeper cluster throws NPE > --------------------------------------------------------------------- > > Key: YARN-4880 > URL: https://issues.apache.org/jira/browse/YARN-4880 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Rohith Sharma K S > Assignee: Sunil G > > While going throw TestZKRMStateStorePerf class , found that we are not initializing variable {{TestingServer curatorTestingServer}} if real zookeeper cluster are passed to utility. But down the line , this variables are used which causes NPE > I tested by passing program arguments which result in NPE > {noformat} > SLF4J: Class path contains multiple SLF4J bindings. > SLF4J: Found binding in [jar:file:/C:/Users/r00902292/.m2/repository/org/slf4j/slf4j-log4j12/1.7.10/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class] > SLF4J: Found binding in [jar:file:/C:/Users/r00902292/.m2/repository/ch/qos/logback/logback-classic/1.1.2/logback-classic-1.1.2.jar!/org/slf4j/impl/StaticLoggerBinder.class] > SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. > SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory] > 2016-03-26 14:47:50,937 INFO [main] recovery.TestZKRMStateStore (TestZKRMStateStorePerf.java:run(119)) - Starting ZKRMStateStorePerf ver.0.1 > java.lang.NullPointerException > at org.apache.hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStorePerf.initStore(TestZKRMStateStorePerf.java:102) > at org.apache.hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStorePerf.run(TestZKRMStateStorePerf.java:156) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90) > at org.apache.hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStorePerf.main(TestZKRMStateStorePerf.java:273) > {noformat} > There are 2 places variable {{curatorTestingServer}} used that need to be guarded with null check. -- This message was sent by Atlassian JIRA (v6.3.4#6332)