Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8BD4A19532 for ; Tue, 29 Mar 2016 14:03:34 +0000 (UTC) Received: (qmail 22335 invoked by uid 500); 29 Mar 2016 14:03:33 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 21099 invoked by uid 500); 29 Mar 2016 14:03:28 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 21045 invoked by uid 99); 29 Mar 2016 14:03:27 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Mar 2016 14:03:27 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id AD78C2C1F6E for ; Tue, 29 Mar 2016 14:03:25 +0000 (UTC) Date: Tue, 29 Mar 2016 14:03:25 +0000 (UTC) From: "Daniel Templeton (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15216044#comment-15216044 ] Daniel Templeton commented on YARN-4807: ---------------------------------------- Thanks, [~yufeigu]! Looks really good. To bring this full circle, I noticed that now you have {{40*1000}} and {{10*1000}} each used twice in {{MockRM}}. Might be worth making those constants (again). Also, it would be really super swell of you could add JavaDocs for the {{MockRM}} and {{MockAM}} methods that you touched, especially since there are now implicit timeouts that can be optionally overridden. > MockAM#waitForState sleep duration is too long > ---------------------------------------------- > > Key: YARN-4807 > URL: https://issues.apache.org/jira/browse/YARN-4807 > Project: Hadoop YARN > Issue Type: Sub-task > Affects Versions: 2.8.0 > Reporter: Karthik Kambatla > Assignee: Yufei Gu > Labels: newbie > Attachments: YARN-4807.001.patch, YARN-4807.002.patch, YARN-4807.003.patch > > > MockAM#waitForState sleep duration (500 ms) is too long. Also, there is significant duplication with MockRM#waitForState. -- This message was sent by Atlassian JIRA (v6.3.4#6332)