Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2898719341 for ; Fri, 25 Mar 2016 17:38:26 +0000 (UTC) Received: (qmail 6719 invoked by uid 500); 25 Mar 2016 17:38:26 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 6677 invoked by uid 500); 25 Mar 2016 17:38:25 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: yarn-issues@hadoop.apache.org Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 6570 invoked by uid 99); 25 Mar 2016 17:38:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Mar 2016 17:38:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id A60A02C1F69 for ; Fri, 25 Mar 2016 17:38:25 +0000 (UTC) Date: Fri, 25 Mar 2016 17:38:25 +0000 (UTC) From: "Bibin A Chundatt (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-4746) yarn web services should convert parse failures of appId to 400 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212141#comment-15212141 ] Bibin A Chundatt commented on YARN-4746: ---------------------------------------- [~stevel@apache.org] Could you please review of latest patch attached. > yarn web services should convert parse failures of appId to 400 > --------------------------------------------------------------- > > Key: YARN-4746 > URL: https://issues.apache.org/jira/browse/YARN-4746 > Project: Hadoop YARN > Issue Type: Bug > Components: webapp > Affects Versions: 2.8.0 > Reporter: Steve Loughran > Assignee: Bibin A Chundatt > Priority: Minor > Attachments: 0001-YARN-4746.patch, 0002-YARN-4746.patch, 0003-YARN-4746.patch, 0003-YARN-4746.patch, 0004-YARN-4746.patch > > > I'm seeing somewhere in the WS API tests of mine an error with exception conversion of a bad app ID sent in as an argument to a GET. I know it's in ATS, but a scan of the core RM web services implies a same problem > {{WebServices.parseApplicationId()}} uses {{ConverterUtils.toApplicationId}} to convert an argument; this throws IllegalArgumentException, which is then handled somewhere by jetty as a 500 error. > In fact, it's a bad argument, which should be handled by returning a 400. This can be done by catching the raised argument and explicitly converting it -- This message was sent by Atlassian JIRA (v6.3.4#6332)